Skip to content

chore(clients): call emitWarningIfUnsupportedVersion from runtimeConfig #3637

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 25, 2022

Conversation

trivikr
Copy link
Member

@trivikr trivikr commented May 25, 2022

Issue

Internal JS-3236
smithy-ts PR smithy-lang/smithy-typescript#549

Description

Calls emitWarningIfVersionUnsupported from runtimeConfig

Testing

Verified that waring is emitted for Node.js <12 only once:

// test.js
const { DynamoDB } = require("../aws-sdk-js-v3/clients/client-dynamodb");
const { S3 } = require("../aws-sdk-js-v3/clients/client-s3");

const dynamodbClient = new DynamoDB();
const s3Client = new S3();
$ fnm use 10
Using Node v10.24.1

$ node test.js
(node:1352) NodeDeprecationWarning: The AWS SDK for JavaScript (v3) will
no longer support Node.js v10.24.1 as of January 1, 2022.
To continue receiving updates to AWS services, bug fixes, and security
updates please upgrade to Node.js 12.x or later.

More information can be found at: https://a.co/1l6FLnu

$ fnm use 12
Using Node v12.22.1

$ node test.js

The warning will change to include Node.js 12.x in #3636


By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@trivikr trivikr requested a review from a team as a code owner May 25, 2022 17:26
@trivikr trivikr merged commit 9cb0805 into aws:main May 25, 2022
@trivikr trivikr deleted the clients-emit-warning branch May 25, 2022 17:56
@github-actions
Copy link

github-actions bot commented Jun 9, 2022

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 9, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants