Skip to content

chore(codegen): use Record type instead of Object #3659

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 3, 2022

Conversation

trivikr
Copy link
Member

@trivikr trivikr commented Jun 2, 2022

Issue

Internal JS-3299

Description

Use Record type in place of Object in aws-typescript-codegen

Testing

TypeScript playground:

const exampleObj = { "one": 1, "two": 2, "three": 3}

const record: Record<string, number> = exampleObj;
const keyStringObj: {[key:string]: number} = exampleObj;

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@trivikr trivikr marked this pull request as ready for review June 2, 2022 22:18
@trivikr trivikr requested a review from a team as a code owner June 2, 2022 22:18
@trivikr trivikr force-pushed the use-record-aws-codegen branch from 25526cf to 27f9d82 Compare June 3, 2022 05:16
@trivikr trivikr merged commit 312adb0 into aws:main Jun 3, 2022
@trivikr trivikr deleted the use-record-aws-codegen branch June 3, 2022 15:43
@github-actions
Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 18, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants