Skip to content

chore(eventstream-serde): remove unused eventMarshaller #3743

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 27, 2022
Merged

chore(eventstream-serde): remove unused eventMarshaller #3743

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
366dbb6
chore(eventstream-serde-node): removeunused eveentMarshaller
trivikr Jun 27, 2022
fc6d871
chore(eventstream-serde-browser): remove unused eventMarshaller
trivikr Jun 27, 2022
054834c
chore(eventstream-serde-node): remove marshaller from package.json
trivikr Jun 27, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion packages/eventstream-serde-browser/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,6 @@
},
"license": "Apache-2.0",
"dependencies": {
"@aws-sdk/eventstream-marshaller": "*",
"@aws-sdk/eventstream-serde-universal": "*",
"@aws-sdk/types": "*",
"tslib": "^2.3.1"
Expand Down
3 changes: 0 additions & 3 deletions packages/eventstream-serde-browser/src/EventStreamMarshaller.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
import { EventStreamMarshaller as EventMarshaller } from "@aws-sdk/eventstream-marshaller";
import { EventStreamMarshaller as UniversalEventStreamMarshaller } from "@aws-sdk/eventstream-serde-universal";
import { Decoder, Encoder, EventStreamMarshaller as IEventStreamMarshaller, Message } from "@aws-sdk/types";

Expand Down Expand Up @@ -28,10 +27,8 @@ export interface EventStreamMarshallerOptions {
* for streaming data although it has lower throughput.
*/
export class EventStreamMarshaller {
private readonly eventMarshaller: EventMarshaller;
private readonly universalMarshaller: UniversalEventStreamMarshaller;
constructor({ utf8Encoder, utf8Decoder }: EventStreamMarshallerOptions) {
this.eventMarshaller = new EventMarshaller(utf8Encoder, utf8Decoder);
this.universalMarshaller = new UniversalEventStreamMarshaller({
utf8Decoder,
utf8Encoder,
Expand Down
1 change: 0 additions & 1 deletion packages/eventstream-serde-node/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,6 @@
},
"license": "Apache-2.0",
"dependencies": {
"@aws-sdk/eventstream-marshaller": "*",
"@aws-sdk/eventstream-serde-universal": "*",
"@aws-sdk/types": "*",
"tslib": "^2.3.1"
Expand Down
3 changes: 0 additions & 3 deletions packages/eventstream-serde-node/src/EventStreamMarshaller.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
import { EventStreamMarshaller as EventMarshaller } from "@aws-sdk/eventstream-marshaller";
import { EventStreamMarshaller as UniversalEventStreamMarshaller } from "@aws-sdk/eventstream-serde-universal";
import { Decoder, Encoder, EventStreamMarshaller as IEventStreamMarshaller, Message } from "@aws-sdk/types";
import { Readable } from "stream";
Expand All @@ -13,10 +12,8 @@ export interface EventStreamMarshallerOptions {
}

export class EventStreamMarshaller {
private readonly eventMarshaller: EventMarshaller;
private readonly universalMarshaller: UniversalEventStreamMarshaller;
constructor({ utf8Encoder, utf8Decoder }: EventStreamMarshallerOptions) {
this.eventMarshaller = new EventMarshaller(utf8Encoder, utf8Decoder);
this.universalMarshaller = new UniversalEventStreamMarshaller({
utf8Decoder,
utf8Encoder,
Expand Down