Skip to content

test(endpoints): remove endpoints functional test #3819

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 22, 2022

Conversation

AllanZhengYP
Copy link
Contributor

@AllanZhengYP AllanZhengYP commented Jul 21, 2022

Issue

The endpoints functional test uses a static set of endpoints to test. When some services introduce new endpoints, it may be different from the one in the test suit, hence causing the test to fail. It has been a recurring issue. We cannot generate test suites based on the endpoints.json either, since endpoints resolver is generated from the same file, it would be testing for nothing.

Since we are planning migrating to all new endpoint resolution algorithms, we are removing this test for now.


By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@AllanZhengYP AllanZhengYP marked this pull request as ready for review July 22, 2022 16:23
@AllanZhengYP AllanZhengYP requested a review from a team as a code owner July 22, 2022 16:23
@AllanZhengYP
Copy link
Contributor Author

Tested in the release automation pipeline.

@AllanZhengYP AllanZhengYP merged commit 0aaceaf into aws:main Jul 22, 2022
@github-actions
Copy link

github-actions bot commented Aug 6, 2022

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 6, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants