feat(upload-abort-controller): add optional abortController param for Upload #3873
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kuhe
reviewed
Sep 21, 2022
| @@ -1,4 +1,5 @@ | |||
| import { PutObjectCommandInput, S3Client, Tag } from "@aws-sdk/client-s3"; | |||
| import { AbortController } from "@aws-sdk/abort-controller"; | |||
There was a problem hiding this comment.
add this as a devDep in package.json?
There was a problem hiding this comment.
It's actually already there:
|
this is limited enough in scope to not require a rebase for status checks |
kuhe
approved these changes
Sep 26, 2022
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
#3872
Description
This optionally exposes the abortController on the
Uploadobject.Testing
Wrote new test in Jest
Additional context
N/A
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.