Skip to content

chore(util-endpoints): return undefined when value absent in referenceRecord #3930

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

trivikr
Copy link
Member

@trivikr trivikr commented Sep 12, 2022

Issue

Noticed during integration tests in #3926

Description

The utility getReferenceValue used to throw error when value is not present. This is not required, as ruleset engine checks if the value if set.

Testing

Unit testing


By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@trivikr trivikr requested a review from a team as a code owner September 12, 2022 19:10
@trivikr trivikr merged commit 5bb234d into aws:main Sep 12, 2022
@trivikr trivikr deleted the return-undefined-value-absent-reference-record branch September 12, 2022 19:59
@github-actions
Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants