Skip to content

chore(deps-dev): bump cucumber to 8.5.3 #3946

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Sep 14, 2022
Merged

Conversation

trivikr
Copy link
Member

@trivikr trivikr commented Sep 14, 2022

Issue

Bumping cucumber for latest features, including help with cleanup.
Refs: #3918

Description

Switches from cucumber to @cucumber/cucumber and update it to version 8.5.3

It provides new features:

  • BeforeEach and AfterEach hooks
  • Searchable HTML reports
  • Native ESM support
  • Write scenarios in Markdown

Testing

Integration tests are successful:

$ yarn test:integration:legacy
yarn run v1.22.19
$ cucumber-js --fail-fast
.......................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................Are you using a Stream of unknown length as the Body of a PutObject request? Consider using Upload instead from @aws-sdk/lib-storage.
............................................................................................................................................................................................................................

149 scenarios (149 passed)
521 steps (521 passed)
1m37.333s (executing steps: 1m36.519s)

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@trivikr trivikr changed the title chore(deps-dev): bump cucumber to version <X> chore(deps-dev): bump cucumber to version 8.5.3 Sep 14, 2022
@trivikr trivikr marked this pull request as ready for review September 14, 2022 15:06
@trivikr trivikr requested a review from a team as a code owner September 14, 2022 15:06
@trivikr trivikr changed the title chore(deps-dev): bump cucumber to version 8.5.3 chore(deps-dev): bump cucumber to 8.5.3 Sep 14, 2022
Copy link
Contributor

@kuhe kuhe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does this change the syntax for running tests for a set of tags?

@trivikr
Copy link
Member Author

trivikr commented Sep 14, 2022

does this change the syntax for running tests for a set of tags?

Nope. Verified by:

$ yarn run cucumber-js --version
8.5.3

$ yarn run cucumber-js --fail-fast -t @sqs
yarn run v1.22.19
$ /local/home/trivikr/workspace/aws-sdk-js-v3/node_modules/.bin/cucumber-js --fail-fast -t @sqs
.......................

3 scenarios (3 passed)
17 steps (17 passed)
0m02.476s (executing steps: 0m02.447s)

@github-actions
Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 29, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants