Skip to content

fix(e2e): delete cloudwatch groups in After call #3951

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 14, 2022

Conversation

trivikr
Copy link
Member

@trivikr trivikr commented Sep 14, 2022

Issue

Refs: #3948

Description

Deletes cloudwatch groups in After call

Testing

No easy way to simulate failed test. The After call was tested in #3948

Success case
$ aws logs describe-log-groups --log-group-name-prefix aws-js-sdk
{
    "logGroups": []
}

$ yarn run cucumber-js --fail-fast -t @cloudwatchlogs
yarn run v1.22.19
$ /local/home/trivikr/workspace/aws-sdk-js-v3/node_modules/.bin/cucumber-js --fail-fast -t @cloudwatchlogs
...........

2 scenarios (2 passed)
5 steps (5 passed)
0m00.254s (executing steps: 0m00.222s)
Done in 1.03s.

$ aws logs describe-log-groups --log-group-name-prefix aws-js-sdk
{
    "logGroups": []
}

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@trivikr trivikr requested a review from a team as a code owner September 14, 2022 21:02
@trivikr trivikr merged commit 8ed83f0 into aws:main Sep 14, 2022
@trivikr trivikr deleted the cloudwatch-delete-after branch September 14, 2022 23:24
@github-actions
Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 29, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants