Skip to content

fix(e2e): delete elasticache resources in After call #3957

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 15, 2022
Merged

fix(e2e): delete elasticache resources in After call #3957

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion features/elasticache/elasticache.feature
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,6 @@ Feature: Amazon ElastiCache
And I describe the cache parameter groups
Then the value at "CacheParameterGroups" should be a list
And the cache parameter group should be described
And I delete the cache parameter group

Scenario: Error handling
Given I create a cache parameter group with name prefix ""
Expand Down
45 changes: 24 additions & 21 deletions features/elasticache/step_definitions/elasticache.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,43 +1,46 @@
const { Before, Given, Then } = require("@cucumber/cucumber");
const { After, Before, Given, Then } = require("@cucumber/cucumber");

Before({ tags: "@elasticache" }, function (scenario, callback) {
Before({ tags: "@elasticache" }, function () {
const { ElastiCache } = require("../../../clients/client-elasticache");
this.service = new ElastiCache({});
callback();
});

Given("I create a cache parameter group with name prefix {string}", function (prefix, callback) {
After({ tags: "@elasticache" }, async function () {
if (this.cacheGroupName) {
await this.service.deleteCacheParameterGroup({ CacheParameterGroupName: this.cacheGroupName });
this.cacheGroupName = undefined;
}
});

Given("I create a cache parameter group with name prefix {string}", async function (prefix) {
this.cacheGroupName = this.uniqueName(prefix);
const params = {
Description: "Description",
CacheParameterGroupName: this.cacheGroupName,
CacheParameterGroupFamily: "memcached1.4",
};
this.request(null, "createCacheParameterGroup", params, callback, false);
try {
this.data = await this.service.createCacheParameterGroup(params);
} catch (error) {
this.error = error;
}
});

Given("the cache parameter group name is in the result", function (callback) {
Given("the cache parameter group name is in the result", async function () {
const name = this.data.CacheParameterGroup.CacheParameterGroupName;
this.assert.equal(name, this.cacheGroupName);
callback();
});

Given("I describe the cache parameter groups", function (callback) {
const params = {
CacheParameterGroupName: this.cacheGroupName,
};
this.request(null, "describeCacheParameterGroups", params, callback);
Given("I describe the cache parameter groups", async function () {
const params = { CacheParameterGroupName: this.cacheGroupName };
try {
this.data = await this.service.describeCacheParameterGroups(params);
} catch (error) {
this.error = error;
}
});

Then("the cache parameter group should be described", function (callback) {
Then("the cache parameter group should be described", function () {
const item = this.data.CacheParameterGroups[0];
this.assert.equal(item.CacheParameterGroupName, this.cacheGroupName);
callback();
});

Then("I delete the cache parameter group", function (callback) {
const params = {
CacheParameterGroupName: this.cacheGroupName,
};
this.request(null, "deleteCacheParameterGroup", params, callback);
});