fix(endpoint): misc fixes for endpoints 2.0 based on service unit tests #4002
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kuhe
commented
Sep 29, 2022
| @@ -2,7 +2,7 @@ import { isValidHostLabel } from "./isValidHostLabel"; | |||
|
|
|||
| describe(isValidHostLabel.name, () => { | |||
| const testCases: Array<[boolean, string]> = [ | |||
| [false, "01010"], | |||
| [true, "01010"], | |||
There was a problem hiding this comment.
I changed this because I saw that subdomains can be made of only numbers.
Hostnames can start with a number too.
trivikr
reviewed
Sep 29, 2022
trivikr
approved these changes
Sep 29, 2022
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have not imported the test cases I used because they are not public yet. Added here are only some revealed fixes and the test case runner code.
REQUIRES: smithy-lang/smithy-typescript#600