fix(endpoint-discovery): delete failed cache entry in blocking operations #4011
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kuhe
force-pushed
the
fix/endpoint-discovery
branch
from
7a324bd to
2545789
Compare
kuhe
commented
Oct 3, 2022
| // because a subsequent blocking request will be stuck | ||
| // in a waiting state if it sees the cache entry | ||
| // but we have already flushed the request queue. | ||
| endpointCache.delete(cacheKey); |
There was a problem hiding this comment.
This conditional was unnecessary.
- the cache entry must be deleted in all error cases to unblock the next awaiting request
- the cache entry placeholder is set below for non-blocking requests anyway
siddsriv
approved these changes
Oct 3, 2022
kuhe
force-pushed
the
fix/endpoint-discovery
branch
from
2545789 to
b8326d5
Compare
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In blocking operations where discovered endpoint is required, the
updateDiscoveredEndpointInCachefunction must resolve or reject.Because the function enters a waiting state if it discovers a cached but incomplete endpoint, it could incorrectly wait indefinitely if the incomplete endpoint is the result of a failed request.