Skip to content

feat(endpoint): add endpoint models for awsJson1.0 services #4073

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

feat(endpoint): add endpoint models for awsJson1.0 services #4073

wants to merge 1 commit into from

Conversation

kuhe
Copy link
Contributor

@kuhe kuhe commented Oct 21, 2022 •
edited
Loading

Issue

internal JS-3670

Description

aws json 1.0 services endpoints 2.0 models

service count:

awsJson1_1: 106,
restJson1: 168,
awsJson1_0: 21,
awsQuery: 17,
restXml: 4,
ec2Query: 1

Testing

  • yarn build:all
  • (cd tests/endpoints-2.0 && npx jest)
  • npx cucumber-js
  • yarn run lerna run test:unit --scope "@aws-sdk/client-*"
  • run S3 ispec.ts

previously:
#4069
#4070

@kuhe kuhe requested a review from a team as a code owner October 21, 2022 19:09
@trivikr trivikr marked this pull request as draft October 21, 2022 20:24
@trivikr
Copy link
Member

trivikr commented Oct 21, 2022

Switching to draft, as v3.194.0 is not out yet.
It will be switched back to ready, post v3.194.0 release and rebase.

@trivikr trivikr marked this pull request as ready for review October 21, 2022 21:57
@kuhe kuhe changed the title feat(endpoint): add endpoint models for restJson1.0 services feat(endpoint): add endpoint models for awsJson1.0 services Oct 21, 2022
@kuhe
Copy link
Contributor Author

kuhe commented Oct 21, 2022

branch is misnamed, I'll close and open a new one

@kuhe kuhe closed this Oct 21, 2022
@kuhe kuhe deleted the feat/endpoints-2.0-restJson1_0 branch October 21, 2022 22:46
@github-actions
Copy link

github-actions bot commented Nov 5, 2022

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 5, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@trivikr trivikr trivikr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kuhe @trivikr