Skip to content

fix(types): extends check of generic in WithSdkStreamMixin #4119

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 31, 2022
Merged

fix(types): extends check of generic in WithSdkStreamMixin #4119

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
791097c
fix(types): Fix issue with WithSdkStreamMixin
Lewenhaupt Oct 28, 2022
32ed83a
fix(streams): apply mixin only to key match instead of type match
kuhe Oct 28, 2022
fc0b4c0
fix(streams): update docs to indicate single key match instead of typ…
Lewenhaupt Oct 28, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions packages/types/src/serde.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,12 +87,12 @@ export interface SdkStreamMixin {
export type SdkStream<BaseStream> = BaseStream & SdkStreamMixin;

/**
* Indicates that any members of type T
* that were of type T[StreamKey] have been extended
* Indicates that the member of type T with
* key StreamKey have been extended
* with the SdkStreamMixin helper methods.
*/
export type WithSdkStreamMixin<T, StreamKey extends keyof T> = {
[key in keyof T]: T[key] extends T[StreamKey] ? SdkStream<T[StreamKey]> : T[key];
[key in keyof T]: key extends StreamKey ? SdkStream<T[StreamKey]> : T[key];
};

/**
Expand Down