Skip to content

fix(endpoint): use regexp to construct template string instead of Function #4135

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

kuhe
Copy link
Contributor

@kuhe kuhe commented Nov 1, 2022

Issue

#4121

Description

  • use regexp to build template string instead of Function.

Testing

existing unit test coverage.

@kuhe kuhe requested a review from a team as a code owner November 1, 2022 20:42
@trivikr
Copy link
Member

trivikr commented Nov 1, 2022

Superceded by #4136

@trivikr trivikr closed this Nov 1, 2022
@github-actions
Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 16, 2022
@kuhe kuhe deleted the fix/unsafe-eval branch November 16, 2022 16:08
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants