chore(types): update @types/node to 14 #4148
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kuhe
changed the title
kuhe
changed the title
kuhe
changed the title
kuhe
force-pushed
the
chore/types-node
branch
from
b6c50a0 to
f34942f
Compare
kuhe
force-pushed
the
chore/types-node
branch
from
f34942f to
fc8ec42
Compare
kuhe
commented
Nov 9, 2022
| @@ -32,7 +32,7 @@ export const sdkStreamMixin = (stream: unknown): SdkStream<Readable> => { | |||
| transformToString: async (encoding?: string) => { | |||
| const buf = await transformToByteArray(); | |||
| if (encoding === undefined || Buffer.isEncoding(encoding)) { | |||
| return fromArrayBuffer(buf.buffer, buf.byteOffset, buf.byteLength).toString(encoding); | |||
| return fromArrayBuffer(buf.buffer, buf.byteOffset, buf.byteLength).toString(encoding as BufferEncoding); | |||
There was a problem hiding this comment.
I am telling Buffer.toString to not typecheck the encoding. This should not be applied upward to encoding?: string because
- I don't think the enumeration is actually exhaustive, but regardless,
- it makes it very hard to make the browser version consistently typed with this one
trivikr
approved these changes
Nov 9, 2022
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
n/a
Description
A yarn issue is blocking my SSO PR, I think this may fix it.
The change should be valid considering we've dropped node 10 and 12 support.