chore(e2e): unset bucket synchronously #4196
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kuhe
force-pushed
the
chore/features-testing
branch
from
c51f412 to
1f1fc3b
Compare
kuhe
commented
Nov 15, 2022
| } else { | ||
| callback(); | ||
| _callback(); | ||
| } | ||
| }); |
There was a problem hiding this comment.
previous code:
if (this.bucket) {
this.request("s3", "deleteBucket", { Bucket: this.bucket }, callback);
this.bucket = undefined;
} else {
callback();
}
trivikr
approved these changes
Nov 15, 2022
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
followup to #4195
Description
noticed that the bucket is expected to be unset synchronously
Testing