Skip to content

fix(middleware-flexible-checksums): append aws-chunked to content-encoding #4368

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 26, 2023

Conversation

kuhe
Copy link
Contributor

@kuhe kuhe commented Jan 25, 2023

Issue

internal

Description

append content-encoding aws-chunked instead of replacing it

Testing

unit tests, manual s3 putObject test

const { S3 } = require("@aws-sdk/client-s3");
const { Readable } = require("stream");

(async () => {
  const s3 = new S3({});

  s3.middlewareStack.add(
    (next, context) => async (args) => {
      const result = await next(args);
      console.log(args.request);
      return result;
    },
    {
      step: "finalizeRequest",
      name: "x",
      tags: [],
    }
  );

  await s3.putObject({
    Bucket: "......",
    Key: "temp.txt",
    Body: Readable.from(Buffer.from("abcdefg")),
    ContentLength: 7,
    ContentEncoding: "gzip",
    ChecksumAlgorithm: "SHA1",
  });
})();

@kuhe kuhe requested a review from a team as a code owner January 25, 2023 21:50
@trivikr trivikr changed the title fix(middleware-flexible-checksums): append content-encoding aws-chunked instead of replacing fix(middleware-flexible-checksums): append aws-chunked to content-encoding Jan 25, 2023
@trivikr
Copy link
Member

trivikr commented Jan 25, 2023

A rebase is needed to include util-utf8-* updates for CI.

@kuhe
Copy link
Contributor Author

kuhe commented Jan 25, 2023

rebased and pushed to rerun CI

@trivikr
Copy link
Member

trivikr commented Jan 26, 2023

Failure in aws-client-api-test were fixed in #4371
Please rebase, and force push

@trivikr
Copy link
Member

trivikr commented Jan 26, 2023

The issue in build:crypto-dependencies was fixed in #4374
Please rebase, and force push to rerun CI.

@kuhe kuhe merged commit dac8a92 into aws:main Jan 26, 2023
@kuhe kuhe deleted the fix/checksum branch January 26, 2023 16:11
@github-actions
Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 10, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants