Skip to content

feat: update client protocol config #437

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

AllanZhengYP
Copy link
Contributor

Issue #, if available:

Description of changes:

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@AllanZhengYP AllanZhengYP added the smithy-codegen Changes regarding supporting smithy model. Will be merged to smithy-codegen branch label Nov 6, 2019
@aws-sdk-js-automation
Copy link

AWS CodeBuild CI Report

  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@codecov-io
Copy link

codecov-io commented Nov 6, 2019

Codecov Report

❗ No coverage uploaded for pull request base (smithy-codegen@6bd0469). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@                Coverage Diff                @@
##             smithy-codegen     #437   +/-   ##
=================================================
  Coverage                  ?   96.27%           
=================================================
  Files                     ?       72           
  Lines                     ?     1235           
  Branches                  ?      223           
=================================================
  Hits                      ?     1189           
  Misses                    ?       46           
  Partials                  ?        0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6bd0469...e1f398e. Read the comment docs.

@mtdowling
Copy link
Member

Is this just a stylistic change? What's the point of this?

@AllanZhengYP
Copy link
Contributor Author

@mtdowling Only a style change

@trivikr
Copy link
Member

trivikr commented Nov 11, 2019

The diff in this PR was moved to #438

@trivikr trivikr deleted the AllanFly120-patch-5 branch November 11, 2019 22:20
@lock
Copy link

lock bot commented Nov 18, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.

@lock lock bot locked as resolved and limited conversation to collaborators Nov 18, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
smithy-codegen Changes regarding supporting smithy model. Will be merged to smithy-codegen branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants