Widen region option in SignatureV4 ctor to accept a region provider and move credentials to be a ctor argument #44
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nd move credentials to be a ctor argument
|
looks good. |
trivikr
referenced
this pull request
in trivikr/aws-sdk-js-v3
Dec 10, 2018
Widen region option in SignatureV4 ctor to accept a region provider and move credentials to be a ctor argument
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change makes
credentialsandregionrequired constructor arguments for the SignatureV4 signer class but allows users to pass in asynchronous providers instead of a string or object literal.regionwas previously required but had to be a string, andcredentialswas previously a required parameter when calling theSignatureV4::presignRequestorSignatureV4::signRequest.Making this change simplifies the calling pattern customers will need to follow to sign requests. They can pass a credential provider to the object's constructor and then invoke
signRequestwith just a request object.