feat(protocol-http): implement SRA HttpRequest #4514
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
milesziemer
force-pushed
the
update-httprequest
branch
from
5be0aa9 to
f6a5766
Compare
kuhe
approved these changes
Mar 10, 2023
| fields: Fields.from( | ||
| this.fields.getAll().map((field) => ({ | ||
| ...field, | ||
| values: [...field.values], |
There was a problem hiding this comment.
Perhaps fields should implement clone. Hard to remember to do this every time.
There was a problem hiding this comment.
Yea I thought about it. I figured we could implement it later if we needed it rather than exposing it now, but I don't have a strong opinion either way.
This change implements the core functionality of HttpRequest for SRA.
New properties were added to the HttpRequest class, old properties
and interfaces were deprecated. Proxy was added for headers and query
properties to maintain backward compatibility. This change does not
include updates to the SDK to use new functionality.
Notes on other changes:
* middleware-host-header and middleware-sdk-transcribe-streaming tests:
URL.port always returns '' if port is set to the default for the
protocol.
* middleware-sdk-transcribe-streaming: Providing URL.hostname with a
string containing the port number does not update the port.
* signature-v4 prepareRequest: See comment in code.
* Field: toString method was changed to only require double quotes on
values with commas. Current tests allow spaces without double quotes.
* Fields: Helper methods were added for getting all fields and creating
a Fields object.
Additional notes:
* When converting between single string header values and a list of
field values, split(",") and join(",") are used to avoid making any
modifications to the original value, preserving compatibility.
* HttpRequest.isInstance was not modified, because doing so might break
compatibility. The check was not looking for the clone method, so
wasn't actually verifying the object was indeed an instance. The method
could easily have been used on a HttpRequest interface from the types
package, and returned true.
milesziemer
force-pushed
the
update-httprequest
branch
from
f6a5766 to
8ae2760
Compare
milesziemer
added a commit
to milesziemer/aws-sdk-js-v3
that referenced
this pull request
Mar 14, 2023
This reverts commit d9d24b0. A bug was found with this commit when using a Symbol as a key, or a non-string as a value in `request.headers`.
milesziemer
added a commit
to milesziemer/aws-sdk-js-v3
that referenced
this pull request
Mar 15, 2023
This reverts commit d9d24b0. A bug was found with this commit when using a Symbol as a key, or a non-string as a value in `request.headers`.
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This change implements the core functionality of HttpRequest for SRA. New properties were added to the HttpRequest class, old properties and interfaces were deprecated. Proxy was added for headers and query properties to maintain backward compatibility. This change does not include updates to the SDK to use new functionality.
Notes on other changes:
Additional notes:
Testing
yarn test:all
Additional context
Because custom middleware can have access to the HttpRequest object, Proxies, getters, and setters are being used
to allow old members of HttpRequest to be used.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.