Update resolveAssumeRoleCredentials.ts #4590
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
fix comment formatting
kuhe
approved these changes
Apr 18, 2023
kuhe
reviewed
Apr 19, 2023
| @@ -100,6 +108,7 @@ export const resolveAssumeRoleCredentials = async ( | |||
| RoleArn: data.role_arn!, | |||
| RoleSessionName: data.role_session_name || `aws-sdk-js-${Date.now()}`, | |||
| ExternalId: data.external_id, | |||
| DurationSeconds: data.duration_seconds, | |||
There was a problem hiding this comment.
this would need to be converted to a number
|
taken over by #4938 |
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#4589
Issue
#4589
Description
Support duration_seconds
Testing
locally by editing
node_modules/@aws-sdk/dist-cjs/resolveAssumeRoleCredentials.jsAdditional context
see issue
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.