Update HTTP binding protocol generation #465
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Codecov Report
@@ Coverage Diff @@
## add-smithy-generator #465 +/- ##
=======================================================
+ Coverage 95.15% 96.5% +1.35%
=======================================================
Files 80 72 -8
Lines 1526 1231 -295
Branches 301 224 -77
=======================================================
- Hits 1452 1188 -264
+ Misses 74 43 -31Continue to review full report at Codecov.
|
mtdowling
reviewed
Nov 22, 2019
| } | ||
|
|
||
| private String serializeToNumber() { | ||
| return "Number(" + getDataSource() + ")"; |
There was a problem hiding this comment.
Can Number actually contain an entire BigDecimal?
...c/main/java/software/amazon/smithy/aws/typescript/codegen/RestJsonDocumentBodyGenerator.java
Outdated
Show resolved
Hide resolved
This commit updates the support for aws.rest-json-1.1 to build atop the refactor of protocol generation done in smithy-typescript. It also introduces support for the aws.rest-json-1.0 protocol. In doing so, general components were built atop the abstractions provided. The aws.rest-json-1.* set of protocols serialize BigInteger and BigDecimal shapes as JSON numbers on the wire, so an implementation of the DocumentMemberSerVisitor was created to fail generation. Implementations of the [DocumentShape[Deser|Ser]Visitor classes are also included to support serde of shapes in request and response bodies. A rest-json implementation of the HttpBindingProtocolGenerator has been created to combine the above aspects and handling of document bodies.
kstich
force-pushed
the
protocol_generator_refactor
branch
from
882df42 to
75ba8cb
Compare
mtdowling
approved these changes
Nov 25, 2019
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
kstich
added a commit
that referenced
this pull request
Nov 25, 2019
This commit updates the support for aws.rest-json-1.1 to build atop the refactor of protocol generation done in smithy-typescript. It also introduces support for the aws.rest-json-1.0 protocol. In doing so, general components were built atop the abstractions provided. The aws.rest-json-1.* set of protocols serialize BigInteger and BigDecimal shapes as JSON numbers on the wire, so an implementation of the DocumentMemberSerVisitor was created to fail generation. Implementations of the [DocumentShape[Deser|Ser]Visitor classes are also included to support serde of shapes in request and response bodies. A rest-json implementation of the HttpBindingProtocolGenerator has been created to combine the above aspects and handling of document bodies.
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit updates the support for
aws.rest-json-1.1to build atopthe refactor of protocol generation done in smithy-typescript. It
also introduces support for the
aws.rest-json-1.0protocol.In doing so, general components were built atop the abstractions
provided. The aws.rest-json-1.* set of protocols serialize BigInteger
and BigDecimal shapes as JSON numbers on the wire, so an implementation
of the DocumentMember[Deser|Ser]Visitor was created to fail generation.
Implementations of the DocumentShape[Deser|Ser]Visitor classes are
also included to support serde of shapes in request and response
bodies.
A rest-json implementation of the
HttpBindingProtocolGeneratorhas beencreated to combine the above aspects and handling of document bodies.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.