feat: Migrate and apply ApplyMd5BodyChecksumMiddleware #493
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
srchase
added
the
smithy-codegen
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
mtdowling
suggested changes
Dec 6, 2019
...t-codegen/src/main/java/software/amazon/smithy/aws/typescript/codegen/AddBuiltinPlugins.java
Outdated
Show resolved
Hide resolved
| } | ||
|
|
||
| private static boolean needsMd5Dep(ServiceShape service) { | ||
| String serviceId = service.getTrait(ServiceTrait.class).map(ServiceTrait::getSdkId).orElse(""); |
There was a problem hiding this comment.
minor: This seems like something that could be moved out into a helper method somewhere
...pescript-codegen/src/main/java/software/amazon/smithy/aws/typescript/codegen/AddMd5Hash.java
Outdated
Show resolved
Hide resolved
| /** | ||
| * Adds Md5Hash if needed. | ||
| */ | ||
| public class AddMd5Hash implements TypeScriptIntegration { |
...ipt-codegen/src/main/java/software/amazon/smithy/aws/typescript/codegen/AddStreamHasher.java
Outdated
Show resolved
Hide resolved
...ipt-codegen/src/main/java/software/amazon/smithy/aws/typescript/codegen/AddStreamHasher.java
Outdated
Show resolved
Hide resolved
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
mtdowling
suggested changes
Dec 6, 2019
...t-codegen/src/main/java/software/amazon/smithy/aws/typescript/codegen/AddBuiltinPlugins.java
Outdated
Show resolved
Hide resolved
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
mtdowling
approved these changes
Dec 7, 2019
AllanZhengYP
approved these changes
Dec 10, 2019
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
author Chase Coalwell <[email protected]> 1575504809 -0800 committer Chase Coalwell <[email protected]> 1576015767 -0800 feat: add md5 body checksum middleware fix: plugin name fix: options name feat: add unsignedPayloadMiddleware feat: remove unsignedPayloadMiddleware feat: add Md5Hash dependencies feat: add md5 body checksum middleware fix: plugin name fix: options name feat: add unsignedPayloadMiddleware feat: remove unsignedPayloadMiddleware fix: logic to include md5 feat: add StreamHasher dependencies fix: update imports fix: missing commas feat: add ApplyMd5BodyChecksum plugin fix: codegen improvements fix: property name
srchase
force-pushed
the
md5-body-checksum
branch
from
0e5009c to
f2b50fe
Compare
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Migrates and applies ApplyMd5BodyChecksumMiddleware
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.