feat(experimentalIdentityAndAuth): add experimentalIdentityAndAuth flag
#5065
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
syall
force-pushed
the
add-experimentalIdentityAndAuth-flag
branch
from
f8323aa to
081c63d
Compare
syall
changed the title
experimentalIdentityAndAuth flag
milesziemer
reviewed
Aug 9, 2023
...pt-codegen/src/main/java/software/amazon/smithy/aws/typescript/codegen/AddAwsAuthPlugin.java
Outdated
Show resolved
Hide resolved
milesziemer
reviewed
Aug 9, 2023
...pt-codegen/src/main/java/software/amazon/smithy/aws/typescript/codegen/AddAwsAuthPlugin.java
Show resolved
Hide resolved
milesziemer
reviewed
Aug 9, 2023
...pt-codegen/src/main/java/software/amazon/smithy/aws/typescript/codegen/AddAwsAuthPlugin.java
Outdated
Show resolved
Hide resolved
milesziemer
reviewed
Aug 9, 2023
...pt-codegen/src/main/java/software/amazon/smithy/aws/typescript/codegen/AddAwsAuthPlugin.java
Outdated
Show resolved
Hide resolved
milesziemer
reviewed
Aug 9, 2023
...codegen/src/main/java/software/amazon/smithy/aws/typescript/codegen/AddAwsRuntimeConfig.java
Outdated
Show resolved
Hide resolved
milesziemer
reviewed
Aug 9, 2023
...odegen/src/main/java/software/amazon/smithy/aws/typescript/codegen/AddEventBridgePlugin.java
Outdated
Show resolved
Hide resolved
syall
force-pushed
the
add-experimentalIdentityAndAuth-flag
branch
from
081c63d to
5c9d7a0
Compare
milesziemer
approved these changes
Aug 9, 2023
…ntalIdentityAndAuth` As part of feature development of `experimentalIdentityAndAuth`, add control branches for existing behavior in existing integrations, particularly `@aws.auth#sigv4` and `@httpBearerTokenAuth`: - `AddAwsAuthPlugin` - `AddAwsRuntimeConfig` - `AddBuiltinPlugins` - `AddEventBridgePlugin` - `AddS3Config` - `AddS3ControlDependency` - `AddTokenAuthPlugin` - `AddEventStreamHandlingDependency` Also, add a section in `CONTRIBUTING.md` about experimental features in `smithy-typescript` used in `aws-sdk-js-v3`.
syall
force-pushed
the
add-experimentalIdentityAndAuth-flag
branch
from
5c9d7a0 to
5677895
Compare
trivikr
approved these changes
Aug 9, 2023
trivikr
changed the title
experimentalIdentityAndAuth flagexperimentalIdentityAndAuth flag
syall
changed the title
experimentalIdentityAndAuth flagexperimentalIdentityAndAuth flag
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Issue number, if available, prefixed with "#"
N/A.
Description
What does this implement/fix? Explain your changes.
Dependent on smithy-lang/smithy-typescript#857.
As part of feature development of
experimentalIdentityAndAuth, addcontrol branches for existing behavior in existing integrations,
particularly
@aws.auth#sigv4and@httpBearerTokenAuth:AddAwsAuthPluginAddAwsRuntimeConfigAddBuiltinPluginsAddEventBridgePluginAddS3ConfigAddS3ControlDependencyAddTokenAuthPluginAddEventStreamHandlingDependencyAlso, add a section in
CONTRIBUTING.mdabout experimental features insmithy-typescriptused in
aws-sdk-js-v3.Testing
How was this change tested?
experimentalIdentityAndAuthflag smithy-lang/smithy-typescript#857 using./gradlew clean build check publishToMavenLocalyarn generate-clientsinaws-sdk-js-v3and observe NO codegen diffs.Additional context
Add any other context about the PR here.
N/A.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.