Skip to content

test(client-s3): disable checksum calculation and validation in legacy tests #6804

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 15, 2025
Merged

test(client-s3): disable checksum calculation and validation in legacy tests #6804

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions features/s3/step_definitions/buckets.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,8 @@ After({ tags: "@buckets" }, function (callback) {
Given("I am using the S3 {string} region", function (region, callback) {
this.s3 = new this.S3({
region: region,
requestChecksumCalculation: "WHEN_REQUIRED",
responseChecksumValidation: "WHEN_REQUIRED",
});
callback();
});
Expand Down Expand Up @@ -235,6 +237,8 @@ When("I create a bucket with a DNS compatible name that contains a dot", functio
Given("I force path style requests", function (callback) {
this.s3 = new this.S3({
forcePathStyle: true,
requestChecksumCalculation: "WHEN_REQUIRED",
responseChecksumValidation: "WHEN_REQUIRED",
});
callback();
});
Expand Down
2 changes: 2 additions & 0 deletions features/s3/step_definitions/hooks.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,8 @@ Before({ tags: "@s3" }, function (scenario, callback) {
const { S3 } = require("../../../clients/client-s3");
this.service = this.s3 = new S3({
maxRetries: 100,
requestChecksumCalculation: "WHEN_REQUIRED",
responseChecksumValidation: "WHEN_REQUIRED",
});
callback();
});
2 changes: 1 addition & 1 deletion features/s3/step_definitions/objects.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,7 +95,7 @@ Then("the object {string} should contain {string}", function (key, contents, nex
});

Then("the HTTP response should have a content length of {int}", function (contentLength, next) {
this.assert.equal(this.data.Body.headers["content-length"], contentLength);
this.assert.equal(this.data.ContentLength, contentLength);
next();
});

Expand Down
Loading