Skip to content

fix: prettify CODE_GEN_OUTPUT_DIR to improve performance #708

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 10, 2020

Conversation

trivikr
Copy link
Member

@trivikr trivikr commented Jan 10, 2020

Issue #, if available:
Fixes #707

Description of changes:

  • prettifies CODE_GEN_OUTPUT_DIR instead of each package to improve performance
  • Tested on c5.4xlarge EC2 instance for generating 99 aws.json-1.1 clients:
    • without this code change:
    $ time yarn generate-clients -m <dir-containing-json-1.1-models>
    ...
    ...
    Done in 205.55s.
    284.17s user 13.39s system 144% cpu 3:25.72 total
    • with this code change:
    $ time yarn generate-clients -m <dir-containing-json-1.1-models>
    ...
    ...
    Done in 132.67s.
    177.20s user 7.31s system 138% cpu 2:12.84 total

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@trivikr trivikr merged commit c589722 into aws:smithy-codegen Jan 10, 2020
@trivikr trivikr deleted the prettify-codegen-faster branch January 10, 2020 02:07
@aws-sdk-js-automation
Copy link

AWS CodeBuild CI Report

  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@lock
Copy link

lock bot commented Jan 17, 2020

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.

@lock lock bot locked as resolved and limited conversation to collaborators Jan 17, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants