fix: multiple XML collection deserialization bugs #768
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kstich
changed the title
mtdowling
suggested changes
Jan 21, 2020
...odegen/src/main/java/software/amazon/smithy/aws/typescript/codegen/XmlShapeDeserVisitor.java
Show resolved
Hide resolved
This comment has been minimized.
This comment has been minimized.
Codecov Report
@@ Coverage Diff @@
## smithy-codegen #768 +/- ##
=================================================
Coverage ? 92.41%
=================================================
Files ? 137
Lines ? 2676
Branches ? 463
=================================================
Hits ? 2473
Misses ? 203
Partials ? 0Continue to review full report at Codecov.
|
This commit fixes a couple issues with generating code to deserialize structure, union, or body members that target collection members. 1. Unflattened shapes that could return multiple entries in their collection but only return one would result in an error at runtime trying to iterate over an object like it was an Array. 2. Unflattened shapes that were not set in the provided output would result in an error at runtime when trying to validate the entry exists element without validating that its parent element existed. This update also bumps the version of smithy-aws-traits to latest.
kstich
force-pushed
the
xml_aggregate_fix
branch
from
c6258d9 to
2ab0649
Compare
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
mtdowling
approved these changes
Jan 21, 2020
This was referenced Jan 21, 2020
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit fixes a couple issues with generating code to deserialize
structure, union, or body members that target collection members.
collection but only return one would result in an error at runtime
trying to iterate over an object like it was an Array.
result in an error at runtime when trying to validate the entry exists
element without validating that its parent element existed.
This update also bumps the version of smithy-aws-traits to latest.
Fixes #765
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.