Skip to content

fix: uri escape presigned url #773

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 22, 2020

Conversation

srchase
Copy link
Contributor

@srchase srchase commented Jan 22, 2020

fix for invalid query string parameter: uri escape presigned url in request

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@aws-sdk-js-automation

This comment has been minimized.

@codecov-io
Copy link

codecov-io commented Jan 22, 2020

Codecov Report

Merging #773 into smithy-codegen will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@                Coverage Diff                 @@
##           smithy-codegen     #773      +/-   ##
==================================================
+ Coverage           92.33%   92.33%   +<.01%     
==================================================
  Files                 140      140              
  Lines                2753     2754       +1     
  Branches              478      478              
==================================================
+ Hits                 2542     2543       +1     
  Misses                211      211
Impacted Files Coverage Δ
packages/middleware-sdk-rds/src/index.ts 87.75% <100%> (+0.25%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cd794e4...edb2294. Read the comment docs.

@aws-sdk-js-automation
Copy link

AWS CodeBuild CI Report

  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@trivikr trivikr merged commit 3928ca1 into aws:smithy-codegen Jan 22, 2020
@srchase srchase deleted the fix-escape-presign-url branch January 22, 2020 18:45
@lock
Copy link

lock bot commented Jan 30, 2020

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.

@lock lock bot locked as resolved and limited conversation to collaborators Jan 30, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants