Skip to content

Convert tests to rspec. #36

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Nov 6, 2020
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion .travis.yml
Original file line number Diff line number Diff line change
@@ -1,3 +1,7 @@
branches:
only:
- master

language: ruby

rvm:
Expand All @@ -6,7 +10,8 @@ rvm:
- 2.5
- 2.6
- 2.7
- jruby
- jruby-9.1
- jruby-9.2

gemfile:
- gemfiles/rails-5.2.gemfile
Expand All @@ -25,5 +30,7 @@ jobs:
rvm: 2.3
- gemfile: gemfiles/rails-6.0.gemfile
rvm: 2.4
- gemfile: gemfiles/rails-6.0.gemfile
rvm: jruby-9.1

bundler_args: --without docs release
4 changes: 4 additions & 0 deletions Gemfile
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,10 @@ group :development do
gem 'rubocop'
end

group :test do
gem 'rspec'
end

group :docs do
gem 'yard'
gem 'yard-sitemap', '~> 1.0'
Expand Down
13 changes: 5 additions & 8 deletions Rakefile
Original file line number Diff line number Diff line change
@@ -1,20 +1,17 @@
# frozen_string_literal: true

require 'rake/testtask'
require 'rubocop/rake_task'

root = File.dirname(__FILE__)

$VERSION = ENV['VERSION'] || File.read(File.join(root, 'VERSION')).strip
$REPO_ROOT = File.dirname(__FILE__)
$VERSION = ENV['VERSION'] || File.read(File.join($REPO_ROOT, 'VERSION')).strip

Dir.glob('**/*.rake').each do |task_file|
load task_file
end

Rake::TestTask.new do |t|
t.libs << 'test'
t.pattern = 'test/**/*_test.rb'
end

desc 'Runs unit tests'
task 'test' => ['test:unit']

RuboCop::RakeTask.new

Expand Down
74 changes: 74 additions & 0 deletions spec/aws/rails/mailer_spec.rb
Original file line number Diff line number Diff line change
@@ -0,0 +1,74 @@
# frozen_string_literal: true

require_relative '../../spec_helper'
require 'mail'

class TestMailer < ActionMailer::Base
layout nil

def deliverable(options = {})
mail(
body: options[:body],
delivery_method: :ses,
from: options[:from],
subject: options[:subject],
to: options[:to]
)
end
end

module Aws
module Rails
describe Mailer do
let(:client_options) do
{
stub_responses: {
send_raw_email: {
message_id: ses_message_id
}
}
}
end

let(:mailer) { Mailer.new(client_options) }

let(:sample_message) do
TestMailer.deliverable(
body: 'Hallo',
from: '[email protected]',
subject: 'This is a test',
to: '[email protected]'
)
end

let(:ses_message_id) do
'0000000000000000-1111111-2222-3333-4444-555555555555-666666'
end

before do
ActionMailer::Base.add_delivery_method(:ses, Mailer, client_options)
end

describe '#settings' do
it 'returns an empty hash' do
expect(mailer.settings).to eq({})
end
end

describe '#deliver' do
it 'delivers the message' do
mailer_data = mailer.deliver!(sample_message).context.params
raw = mailer_data[:raw_message][:data].to_s
raw.gsub!("\r\nHallo", "ses-message-id: #{ses_message_id}\r\n\r\nHallo")
expect(raw).to eq sample_message.to_s
expect(mailer_data[:destinations]).to eq sample_message.destinations
end

it 'delivers with action mailer' do
message = sample_message.deliver_now
expect(message.header[:ses_message_id].value).to eq ses_message_id
end
end
end
end
end
32 changes: 32 additions & 0 deletions spec/aws/rails/railtie_spec.rb
Original file line number Diff line number Diff line change
@@ -0,0 +1,32 @@
# frozen_string_literal: true

require_relative '../../spec_helper'

module Aws
module Rails

describe 'Railtie' do
it 'adds action mailer delivery method' do
expect(ActionMailer::Base.delivery_methods[:ses]).to eq Aws::Rails::Mailer
end

it 'sets the Aws logger' do
expect(Aws.config[:logger]).to eq ::Rails.logger
end

context 'rails encrypted credentials' do
let(:rails_creds) { ::Rails.application.credentials.aws }
it 'sets aws credentials' do
expect(Aws.config[:access_key_id]).to eq rails_creds[:access_key_id]
expect(Aws.config[:secret_access_key]).to eq rails_creds[:secret_access_key]
end

it 'does not load non credential keys into aws config' do
expect(rails_creds[:non_credential_key]).not_to be_nil
expect(Aws.config[:non_credential_key]).to be_nil
end
end

end
end
end
File renamed without changes.
File renamed without changes.
File renamed without changes.
4 changes: 2 additions & 2 deletions test/test_helper.rb → spec/spec_helper.rb
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
# frozen_string_literal: true

require 'minitest/autorun'
ENV['RAILS_ENV'] = 'test'
require 'rspec'

ENV['RAILS_ENV'] = 'test'
require_relative 'dummy/config/application'

Rails.application.initialize!
2 changes: 1 addition & 1 deletion tasks/release
71 changes: 0 additions & 71 deletions test/aws/rails/mailer_test.rb

This file was deleted.

27 changes: 0 additions & 27 deletions test/aws/rails/railtie_test.rb

This file was deleted.