ActiveSupport::Notifications instrumentation of aws sdk client calls #37
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mullermp
reviewed
Nov 7, 2020
mullermp
approved these changes
Nov 10, 2020
README.md
Outdated
Comment on lines
128
to
131
| Example usage in `config/capplication.rb` | ||
| ```ruby | ||
| Aws::Rails.instrument_sdk_operations | ||
| ``` |
There was a problem hiding this comment.
let's prefer to make an initializer here
| @@ -1,10 +1,13 @@ | |||
| # frozen_string_literal: true | |||
|
|
|||
| require_relative 'aws/rails/mailer' | |||
| require_relative 'aws/rails/notifications_instrument_plugin' | |||
There was a problem hiding this comment.
you're going to need to rebase this against my change once merged, or vice versa, up to you.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #14
Description of changes:
Support ActiveSupport::Notification instrumentation of all AWS SDK client operations.
This is currently not enabled by default and requires calling
Aws::Rails.instrument_sdk_operations(eg, can be done in config/application.rb or in environment configs).Instrumentation adds ~0.2ms per call (which is an ~20% increase outside of network calls).
Note: I had to inspect all loaded Aws modules for service modules and add the handler to each one - adding to the seahorse base client does not work at this stage.
Open Questions:
Aws::Rails.instrument_sdk_operations(See above explanation)<operation>.<serviceId>.aws(Note, this naming matches the patterns used in rails).By submitting this pull request, I confirm that my contribution is made under
the terms of the Apache 2.0 license.