Skip to content

Add SSL option support across all drivers. #258

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: v2
Choose a base branch
from

Conversation

LibbyKen
Copy link

@LibbyKen LibbyKen commented Jan 8, 2025

Issue #, if available: Closes #226

Description of changes:
Adding SSL option support across all drivers.

SSL syntax docs

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@LibbyKen LibbyKen requested a review from a team as a code owner January 8, 2025 04:28
@LibbyKen LibbyKen marked this pull request as draft January 8, 2025 04:32
@LibbyKen LibbyKen marked this pull request as ready for review January 8, 2025 04:59
@LibbyKen LibbyKen self-assigned this Jan 8, 2025
@simonmarty simonmarty self-requested a review January 17, 2025 17:20
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 20.00000% with 56 lines in your changes missing coverage. Please review.

Project coverage is 24.13%. Comparing base (0d48fb8) to head (9b7a44d).
Report is 2 commits behind head on v2.

Files with missing lines Patch % Lines
...ws/secretsmanager/sql/AWSSecretsManagerDriver.java 0.00% 18 Missing ⚠️
...manager/sql/AWSSecretsManagerPostgreSQLDriver.java 0.00% 8 Missing ⚠️
...anager/sql/AWSSecretsManagerMSSQLServerDriver.java 0.00% 6 Missing ⚠️
...etsmanager/sql/AWSSecretsManagerMariaDBDriver.java 0.00% 6 Missing ⚠️
...cretsmanager/sql/AWSSecretsManagerMySQLDriver.java 0.00% 6 Missing ⚠️
...secretsmanager/sql/AWSSecretsManagerDb2Driver.java 0.00% 4 Missing ⚠️
...retsmanager/sql/AWSSecretsManagerOracleDriver.java 0.00% 4 Missing ⚠️
...tsmanager/sql/AWSSecretsManagerRedshiftDriver.java 0.00% 3 Missing ⚠️
.../com/amazonaws/secretsmanager/util/URLBuilder.java 93.33% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##                 v2     #258      +/-   ##
============================================
- Coverage     24.86%   24.13%   -0.73%     
- Complexity       41       49       +8     
============================================
  Files            12       13       +1     
  Lines           366      435      +69     
  Branches         45       62      +17     
============================================
+ Hits             91      105      +14     
- Misses          273      327      +54     
- Partials          2        3       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

provide option to enforce ssl
2 participants