Skip to content

Remove expected attributes from deleting session. #11

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from

Conversation

JDutil
Copy link
Contributor

@JDutil JDutil commented Jan 25, 2017

Fixes #10

I would merge #9 first as that fixes the specs. The failure here is currently on master branch.

djmassad pushed a commit to FronteraConsulting/aws-sessionstore-dynamodb-ruby that referenced this pull request Apr 25, 2017
@cjyclaire
Copy link
Contributor

Hmm taking a second look at the diff, the ServiceError change looks good to me, yet for user agent diff and spec diff, may I ask are they causing trouble for you?

@JDutil
Copy link
Contributor Author

JDutil commented Aug 23, 2017

@cjyclaire no they aren't and I'm not sure why they are in the diff. I tried updating this PR last night with latest work and noticed these unrelated diffs being included, and was too tired to work on fixing at the time. I'll revisit this to clean up the diff.

Also FYI I'm not sure that #15 was configured correctly because these commits didn't trigger any build, but maybe that's because this is an older PR? Perhaps I need to reopen a new one to get it to build once I clean up the diff?

@cjyclaire
Copy link
Contributor

Hmm, weird, you can open a new one if it gets messy ; ) I'll take a look and merge it. Thanks!

@JDutil
Copy link
Contributor Author

JDutil commented Aug 23, 2017

For some reason this PR doesn't even include the main fix anymore...

Essentially all I wanted to do was change:

# @return [Hash] Options for deleting session.
def delete_opts(sid)
     merge_all(table_opts(sid), expected_attributes(sid))
end

to

# @return [Hash] Options for deleting session.
def delete_opts(sid)
      table_opts(sid)
end

When deleting records there is no reason to ensure they have those expected_attributes we can just delete the record.

@JDutil
Copy link
Contributor Author

JDutil commented Aug 23, 2017

Closing for now until I get a chance to fix up this PR as intended again.

@JDutil JDutil closed this Aug 23, 2017
@JDutil JDutil deleted the hotfix/10 branch September 8, 2017 23:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove expected attributes from delete session
2 participants