Skip to content

New version refresh #37

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 24 commits into from
Oct 27, 2024
Merged

New version refresh #37

merged 24 commits into from
Oct 27, 2024

Conversation

mullermp
Copy link
Contributor

@mullermp mullermp commented Oct 20, 2024 •
edited
Loading

Does a bunch of things:

  • Bump to major version 3
  • Uses Rack 3 without the compatibility gem
  • Rubocop
  • Updated CI
  • Modern code and clean up
  • Updated README

Simultaneously improves aws-sdk-rails integration (PR TBD)

Closes #33

@mullermp mullermp mentioned this pull request Oct 20, 2024
Closed
alextwoods
alextwoods reviewed Oct 22, 2024
View reviewed changes
Copy link
Contributor

@alextwoods alextwoods left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

alextwoods
alextwoods approved these changes Oct 25, 2024
View reviewed changes
Copy link
Contributor

@alextwoods alextwoods left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, looks good!

@mullermp mullermp merged commit b18dbea into main Oct 27, 2024
7 checks passed
@mullermp mullermp deleted the new-version-refresh branch October 27, 2024 23:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alextwoods alextwoods alextwoods approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mullermp @alextwoods