Use ENV with precedence over YAML configuration #39
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Investigating jruby... I'm not sure if it's related. |
|
The issue is with the json gem. @thomaswitt feel free to try your code with this github/branch and the aws-sdk-rails PR. |
jterapin
approved these changes
Nov 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to discussions in aws/aws-sdk-rails#139
Soft breaking change. This change makes ENV variables take precedence over YAML files, similar to how it works in the Ruby SDK. This is necessary so that the config file path can be set in ENV, then that config file, if present, would be read and used. The values in the config file would not take precedence over ENV.