Avoid infinite loop during session garbage collection. #6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lection#scan method was not properly using the last_item parameter. This causes the #scan to repeatedly rescan the same set of DDB items instead of advancing through the items in the table. If all / many sessions were expired the gc would seem to work since gc deletes old sessions; however, for a real live system, the gc will appear to hang.
|
Nice catch! Pretty clear that this was the intent all along, so this looks like a no-brainer. Thanks! |
awood45
added a commit
that referenced
this pull request
Mar 9, 2016
Avoid infinite loop during session garbage collection.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the same issue as #4 but this PR includes updated spec test.
The GarbageColection#scan method was not properly using the last_item parameter. This causes the #scan to repeatedly rescan the same set of DDB items instead of advancing through the items in the table. If all / many sessions were expired the gc would seem to work since gc deletes old sessions; however, for a real live system, the gc will appear to hang.