-
Notifications
You must be signed in to change notification settings - Fork 27
Add SageMaker hosting integ test #18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,42 @@ | ||
# Copyright 2019 Amazon.com, Inc. or its affiliates. All Rights Reserved. | ||
# | ||
# Licensed under the Apache License, Version 2.0 (the "License"). | ||
# You may not use this file except in compliance with the License. | ||
# A copy of the License is located at | ||
# | ||
# http://www.apache.org/licenses/LICENSE-2.0 | ||
# | ||
# or in the "license" file accompanying this file. This file is distributed | ||
# on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either | ||
# express or implied. See the License for the specific language governing | ||
# permissions and limitations under the License. | ||
from __future__ import absolute_import | ||
|
||
import os | ||
|
||
from sagemaker import utils | ||
from sagemaker.mxnet.model import MXNetModel | ||
|
||
from test.integration import RESOURCE_PATH | ||
import timeout | ||
|
||
DEFAULT_HANDLER_PATH = os.path.join(RESOURCE_PATH, 'default_handlers') | ||
MODEL_PATH = os.path.join(DEFAULT_HANDLER_PATH, 'model.tar.gz') | ||
SCRIPT_PATH = os.path.join(DEFAULT_HANDLER_PATH, 'model', 'code', 'empty_module.py') | ||
|
||
|
||
def test_hosting(sagemaker_session, ecr_image, instance_type): | ||
prefix = 'mxnet-serving/default-handlers' | ||
model_data = sagemaker_session.upload_data(path=MODEL_PATH, key_prefix=prefix) | ||
model = MXNetModel(model_data, | ||
'SageMakerRole', | ||
SCRIPT_PATH, | ||
image=ecr_image, | ||
sagemaker_session=sagemaker_session) | ||
|
||
endpoint_name = utils.unique_name_from_base('test-mxnet-serving') | ||
with timeout.timeout_and_delete_endpoint_by_name(endpoint_name, sagemaker_session): | ||
predictor = model.deploy(1, instance_type, endpoint_name=endpoint_name) | ||
|
||
output = predictor.predict([[1, 2]]) | ||
assert [[4.9999918937683105]] == output |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,135 @@ | ||
# Copyright 2019 Amazon.com, Inc. or its affiliates. All Rights Reserved. | ||
# | ||
# Licensed under the Apache License, Version 2.0 (the "License"). You | ||
# may not use this file except in compliance with the License. A copy of | ||
# the License is located at | ||
# | ||
# http://aws.amazon.com/apache2.0/ | ||
# | ||
# or in the "license" file accompanying this file. This file is | ||
# distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF | ||
# ANY KIND, either express or implied. See the License for the specific | ||
# language governing permissions and limitations under the License. | ||
from __future__ import absolute_import | ||
|
||
from contextlib import contextmanager | ||
import logging | ||
import signal | ||
from time import sleep | ||
|
||
from awslogs.core import AWSLogs | ||
from botocore.exceptions import ClientError | ||
|
||
LOGGER = logging.getLogger('timeout') | ||
|
||
|
||
class TimeoutError(Exception): | ||
pass | ||
|
||
|
||
@contextmanager | ||
def timeout(seconds=0, minutes=0, hours=0): | ||
""" | ||
Add a signal-based timeout to any block of code. | ||
If multiple time units are specified, they will be added together to determine time limit. | ||
Usage: | ||
with timeout(seconds=5): | ||
my_slow_function(...) | ||
Args: | ||
- seconds: The time limit, in seconds. | ||
- minutes: The time limit, in minutes. | ||
- hours: The time limit, in hours. | ||
""" | ||
|
||
limit = seconds + 60 * minutes + 3600 * hours | ||
|
||
def handler(signum, frame): | ||
raise TimeoutError('timed out after {} seconds'.format(limit)) | ||
|
||
try: | ||
signal.signal(signal.SIGALRM, handler) | ||
signal.alarm(limit) | ||
|
||
yield | ||
finally: | ||
signal.alarm(0) | ||
|
||
|
||
@contextmanager | ||
def timeout_and_delete_endpoint_by_name(endpoint_name, sagemaker_session, seconds=0, minutes=45, hours=0): | ||
with timeout(seconds=seconds, minutes=minutes, hours=hours) as t: | ||
no_errors = False | ||
try: | ||
yield [t] | ||
no_errors = True | ||
finally: | ||
attempts = 3 | ||
|
||
while attempts > 0: | ||
attempts -= 1 | ||
try: | ||
sagemaker_session.delete_endpoint(endpoint_name) | ||
LOGGER.info('deleted endpoint {}'.format(endpoint_name)) | ||
|
||
_show_logs(endpoint_name, 'Endpoints', sagemaker_session) | ||
if no_errors: | ||
_cleanup_logs(endpoint_name, 'Endpoints', sagemaker_session) | ||
return | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. changed the |
||
except ClientError as ce: | ||
if ce.response['Error']['Code'] == 'ValidationException': | ||
# avoids the inner exception to be overwritten | ||
pass | ||
# trying to delete the resource again in 10 seconds | ||
sleep(10) | ||
|
||
|
||
@contextmanager | ||
def timeout_and_delete_model_with_transformer(transformer, sagemaker_session, seconds=0, minutes=0, hours=0): | ||
with timeout(seconds=seconds, minutes=minutes, hours=hours) as t: | ||
no_errors = False | ||
try: | ||
yield [t] | ||
no_errors = True | ||
finally: | ||
attempts = 3 | ||
|
||
while attempts > 0: | ||
attempts -= 1 | ||
try: | ||
transformer.delete_model() | ||
LOGGER.info('deleted SageMaker model {}'.format(transformer.model_name)) | ||
|
||
_show_logs(transformer.model_name, 'Models', sagemaker_session) | ||
if no_errors: | ||
_cleanup_logs(transformer.model_name, 'Models', sagemaker_session) | ||
return | ||
except ClientError as ce: | ||
if ce.response['Error']['Code'] == 'ValidationException': | ||
pass | ||
sleep(10) | ||
|
||
|
||
def _show_logs(resource_name, resource_type, sagemaker_session): | ||
log_group = '/aws/sagemaker/{}/{}'.format(resource_type, resource_name) | ||
try: | ||
# print out logs before deletion for debuggability | ||
LOGGER.info('cloudwatch logs for log group {}:'.format(log_group)) | ||
logs = AWSLogs(log_group_name=log_group, log_stream_name='ALL', start='1d', | ||
aws_region=sagemaker_session.boto_session.region_name) | ||
logs.list_logs() | ||
except Exception: | ||
LOGGER.exception('Failure occurred while listing cloudwatch log group %s. Swallowing exception but printing ' | ||
'stacktrace for debugging.', log_group) | ||
|
||
|
||
def _cleanup_logs(resource_name, resource_type, sagemaker_session): | ||
log_group = '/aws/sagemaker/{}/{}'.format(resource_type, resource_name) | ||
try: | ||
# print out logs before deletion for debuggability | ||
LOGGER.info('deleting cloudwatch log group {}:'.format(log_group)) | ||
cwl_client = sagemaker_session.boto_session.client('logs') | ||
cwl_client.delete_log_group(logGroupName=log_group) | ||
LOGGER.info('deleted cloudwatch log group: {}'.format(log_group)) | ||
except Exception: | ||
LOGGER.exception('Failure occurred while cleaning up cloudwatch log group %s. ' | ||
'Swallowing exception but printing stacktrace for debugging.', log_group) |
Binary file not shown.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
https://github.com/aws/sagemaker-mxnet-serving-container/blob/master/test/unit/test_default_inference_handler.py#L19
We're still using mxnet :(
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good catch - fixed