Add batch transform test and remove extra MNIST images from test resources #19
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…om test resources
ChoiByungWook
previously approved these changes
Jun 14, 2019
| with timeout.timeout_and_delete_model_with_transformer(transformer, sagemaker_session, minutes=20): | ||
| input_data = sagemaker_session.upload_data(path=DATA_PATH, key_prefix=s3_prefix) | ||
|
|
||
| job_name = utils.unique_name_from_base('test-mxnet-serving') |
There was a problem hiding this comment.
test-mxnet-batch-transform?
ChoiByungWook
approved these changes
Jun 14, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
This change adds a batch transform test to ensure the resulting image is compatible with SageMaker Batch Transform. In the process, I also noticed that only one of the JSON MNIST images was actually used, so I deleted the other nine.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.