File tree Expand file tree Collapse file tree 2 files changed +7
-5
lines changed Expand file tree Collapse file tree 2 files changed +7
-5
lines changed Original file line number Diff line number Diff line change @@ -1457,11 +1457,11 @@ def volume_size_supported(instance_type: str) -> bool:
1457
1457
# Any instance type with a "d" in the instance family (i.e. c5d, p4d, etc)
1458
1458
# + g5 or g6 or p5 does not support attaching an EBS volume.
1459
1459
family = parts [0 ]
1460
- return (
1461
- "d" not in family
1462
- and not family . startswith ( "g5" )
1463
- and not family . startswith ( "g6" )
1464
- and not family .startswith ("p5" )
1460
+
1461
+ unsupported_families = [ "g5" , "g6" , "p5" , "trn1" ]
1462
+
1463
+ return "d" not in family and not any (
1464
+ family .startswith (prefix ) for prefix in unsupported_families
1465
1465
)
1466
1466
except Exception as e :
1467
1467
raise ValueError (f"Failed to parse instance type '{ instance_type } ': { str (e )} " )
Original file line number Diff line number Diff line change @@ -1815,6 +1815,8 @@ def test_volume_size_not_supported(self):
1815
1815
"local" ,
1816
1816
"local_gpu" ,
1817
1817
ParameterString (name = "InstanceType" , default_value = "ml.m4.xlarge" ),
1818
+ "ml.trn1.32xlarge" ,
1819
+ "ml.trn1n.32xlarge" ,
1818
1820
]
1819
1821
1820
1822
for instance in instances_that_dont_support_volume_size :
You can’t perform that action at this time.
0 commit comments