Skip to content

fix: trn1 instance family does not support volume size #4828

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 13, 2024

Conversation

evakravi
Copy link
Member

Issue #, if available:

Description of changes:
When a trn1 instance family is used, the PySDK would automatically use volume size argument when creating the endpoint config. However, this instance family does not support attaching an ebs volume, hence volume size argument throws a service exception. This PR updates the volume_size_supported function to correctly identify trn1 instance types as not supporting volume size.

Testing done:
Unit tests added.

Merge Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.

General

  • I have read the CONTRIBUTING doc
  • I certify that the changes I am introducing will be backward compatible, and I have discussed concerns about this, if any, with the Python SDK team
  • I used the commit message format described in CONTRIBUTING
  • I have passed the region in to all S3 and STS clients that I've initialized as part of this change.
  • I have updated any necessary documentation, including READMEs and API docs (if appropriate)

Tests

  • I have added tests that prove my fix is effective or that my feature works (if appropriate)
  • I have added unit and/or integration tests as appropriate to ensure backward compatibility of the changes
  • I have checked that my tests are not configured for a specific region or account (if appropriate)
  • I have used unique_name_from_base to create resource names in integ tests (if appropriate)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@evakravi evakravi requested a review from a team as a code owner August 12, 2024 19:27
@evakravi evakravi requested a review from zhaoqizqwang August 12, 2024 19:27
@@ -1462,6 +1462,7 @@ def volume_size_supported(instance_type: str) -> bool:
and not family.startswith("g5")
and not family.startswith("g6")
and not family.startswith("p5")
and not family.startswith("trn1")
Copy link

@yusharon yusharon Aug 12, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

unsupported_families = ["g5", "g6", "p5", "trn1"]
return not any(family.startswith(prefix) for prefix in unsupported_families)

not a blocker, but I think it might be more concise to write it as above.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks, i agree that that's def a better organization

@pintaoz-aws pintaoz-aws merged commit 6b6e6e2 into aws:master Aug 13, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants