fix: fix tags in deploy call for generic estimators #1146
Conversation
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
| kms_key (str): The ARN of the KMS key that is used to encrypt the | ||
| data on the storage volume attached to the instance hosting the | ||
| endpoint. | ||
| data_capture_config (sagemaker.model_monitor.DataCaptureConfig): Specifies | ||
| configuration related to Endpoint data capture for use with | ||
| Amazon SageMaker Model Monitoring. Default: None. | ||
| tags(List[dict[str, str]]): Optional. The list of tags to attach to this specific | ||
| endpoint. Example: | ||
| >>> tags = [{'Key': 'tagname', 'Value': 'tagvalue'}] |
There was a problem hiding this comment.
do you need newlines around the ">>>" line for the formatting to work out?
There was a problem hiding this comment.
Looks like the >>> doesn't work as intended as shown here: https://sagemaker.readthedocs.io/en/v1.45.0/analytics.html#sagemaker.analytics.HyperparameterTuningJobAnalytics.tuning_ranges
Will fix in another PR D:
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Issue #, if available:
#1120
Originally, the
estimator'sdeployfunction supported tags by utilizing kwargs. This would run into problems depending on if each inheritedestimator'screate_modelfunction was able to handle kwargs in the function. This causes problems as reported for the user above, who is using tags for a generic estimator class.Description of changes:
Make tags an explicit parameter in the Estimator's
deployfunction, similar to the Model'sdeployfunction. This will end up not using kwargs to pass tags and not forcecreate_modelfunction to handle it.Merge Checklist
Put an
xin the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.