Skip to content

Update default versions to TensorFlow 1.6 and MXNet 1.1 #118

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Apr 2, 2018

Conversation

winstonaws
Copy link
Contributor

Also bumping our minor version up, since TensorFlow 1.6 / MXNet 1.1 may have some backwards incompatible API changes.

Also includes a minor change to integ tests - removed the framework version parameter from the TF/MXNet async fit tests. These tests cover the same cases as their synchronous fit tests.

@winstonaws winstonaws requested a review from owen-t April 2, 2018 01:57
@owen-t
Copy link
Contributor

owen-t commented Apr 2, 2018

How do customers find out the versions of TF or mxnet we support?

owen-t
owen-t previously approved these changes Apr 2, 2018
Copy link
Contributor

@owen-t owen-t left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to give customers a clear way to find supported versions of each DL framework.

@codecov-io
Copy link

codecov-io commented Apr 2, 2018

Codecov Report

Merging #118 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff           @@
##           master    #118   +/-   ##
======================================
  Coverage    90.4%   90.4%           
======================================
  Files          36      36           
  Lines        2407    2407           
======================================
  Hits         2176    2176           
  Misses        231     231
Impacted Files Coverage Δ
src/sagemaker/mxnet/defaults.py 100% <100%> (ø) ⬆️
src/sagemaker/tensorflow/defaults.py 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6184b22...df8008a. Read the comment docs.

@winstonaws winstonaws merged commit 2d1d5cf into aws:master Apr 2, 2018
apacker pushed a commit to apacker/sagemaker-python-sdk that referenced this pull request Nov 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants