Skip to content

Fix inaccurate linear learner hyper-parameter and sagemaker version in doc and readme #120

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Apr 3, 2018

Conversation

yangaws
Copy link
Contributor

@yangaws yangaws commented Apr 2, 2018

1, Fix inaccurate range and doc for linear learner hyper-parameters
2, Fix the inaccurate version in doc and readme

@yangaws yangaws requested a review from ChoiByungWook April 2, 2018 21:30
CHANGELOG.rst Outdated
========

* bug-fix: AmazonEstimators: fix valid range of hyper-parameter 'loss' in linear learner

1.2.0
========
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This isn't your fault, but can you make sure the equal signs line up with the version.

1.2.0

Thanks!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for pointing out.

Formats of change log fixed.

ChoiByungWook
ChoiByungWook previously approved these changes Apr 2, 2018
@codecov-io
Copy link

codecov-io commented Apr 3, 2018

Codecov Report

Merging #120 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #120   +/-   ##
=======================================
  Coverage   90.27%   90.27%           
=======================================
  Files          36       36           
  Lines        2438     2438           
=======================================
  Hits         2201     2201           
  Misses        237      237
Impacted Files Coverage Δ
src/sagemaker/amazon/linear_learner.py 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 17d24a1...a69d7c7. Read the comment docs.

@yangaws
Copy link
Contributor Author

yangaws commented Apr 3, 2018

Bump version up to 1.2.2 in this PR

@yangaws yangaws merged commit 54c764c into aws:master Apr 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants