doc: change "associate" to "create" for OpenID connector #1208
Conversation
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
| @@ -82,12 +82,12 @@ IAM role-based operator deployment | |||
| Before you can deploy your operator using an IAM role, associate an OpenID Connect (OIDC) provider with your role to | |||
| authenticate with the IAM service. | |||
|
|
|||
| Associate an OpenID Connect Provider to Your Instance | |||
| Create an OpenID Connect Provider to Your Instance | |||
There was a problem hiding this comment.
"Create x to y" doesn't make sense. Change to "Create x for y", e.g. Create an OpenID Connect Provider for Your Cluster?
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | ||
|
|
||
| Create an OIDC identity provider for your cluster. If your | ||
| cluster is managed by EKS, then your cluster will already have an OIDC | ||
| attached to it. | ||
| attached to it and below command will associate it with IAM. |
There was a problem hiding this comment.
Can we reword to be a little more precise?
...have an OIDC attached to it. The following command will associate the OIDC provider with your EKS cluster.
| Create an OIDC identity provider for your cluster. If your | ||
| cluster is managed by EKS, then your cluster will already have an OIDC |
There was a problem hiding this comment.
It is confusing to say we are creating an OIDC provider while at the same time we say one is already "attached to it". I know the eksctl docs are inconsistent on the issue, but we should be consistent so that customers are not confused. Can address now or when we revisit this as part of Arun's feedback.
There was a problem hiding this comment.
This is confusing for me as well I think for EKS 1.13 version they had to create and associate and later version they just need to associate. I can double check.
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
| Create an OIDC identity provider for your cluster. If your | ||
| cluster is managed by EKS, then your cluster will already have an OIDC | ||
| attached to it. | ||
| Create an OIDC identity provider for your cluster. |
There was a problem hiding this comment.
Why are we repeating the header here? Also is it OpenID Connect Provider or OIDC identity provider?
| cluster is managed by EKS, then your cluster will already have an OIDC | ||
| attached to it. | ||
| Create an OIDC identity provider for your cluster. | ||
| The following command will create and associate an OIDC provider |
There was a problem hiding this comment.
I might say "the following instructions" rather than the following command, as what comes after isn't directly a command.
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
laurenyu
changed the title
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
laurenyu
changed the title
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Description of changes: The paragraph was mis leading for users as an optional but creating open ID connector was a required steps for EKS user.
Testing done:
Merge Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.