breaking: change Airflow model_config order; make instance_type optional in model_config and Model.prepare_container_def #1558
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
This is motivated by the Airflow
model_config
method unnecessarily requiringinstance_type
even though the parameter is unused. The reasonprepare_container_def
might useinstance_type
is because for Framework models, the instance type is used to pick "cpu" or "gpu" for the image tag if the tag is not provided. However, the base class's function need not require the argument.Due to the maze of inheritance, I chose not to remove the arg entirely. This is because the various
_create_sagemaker_model()
calls would need to be modified (and perhaps re-implemented in specific subclasses) so thatself.image
is populated before callingself.prepare_container_def
.The other improvement that can be saved for a separate PR is to make
instance_type
optional in each framework's implementation ofprepare_container_def
ifself.image is not None
.Testing done:
unit tests
Merge Checklist
Put an
x
in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.General
Tests
unique_name_from_base
to create resource names in integ tests (if appropriate)By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.