Add support for file:// URI as the input for LocalMode training data #168
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…passing uploading to/downloading from S3.
Codecov Report
@@ Coverage Diff @@
## master #168 +/- ##
==========================================
- Coverage 90.63% 90.57% -0.07%
==========================================
Files 37 37
Lines 2478 2504 +26
==========================================
+ Hits 2246 2268 +22
- Misses 232 236 +4
Continue to review full report at Codecov.
|
iquintero
force-pushed
the
local_mode_phase1
branch
from
b6d5abf to
e656965
Compare
Also fix some TODOs here and there.
iquintero
force-pushed
the
local_mode_phase1
branch
from
e656965 to
6f1cf40
Compare
iquintero
changed the title
owen-t
previously approved these changes
May 8, 2018
iquintero
force-pushed
the
local_mode_phase1
branch
from
ecd4452 to
23be9d1
Compare
owen-t
reviewed
May 8, 2018
README.rst
Outdated
| @@ -184,7 +187,7 @@ For detailed examples of running docker in local mode, see: | |||
| A few important notes: | |||
|
|
|||
| - Only one local mode endpoint can be running at a time | |||
| - Since the data are pulled from S3 to your local environment, please ensure you have sufficient space. | |||
| - Since the data is pulled from S3 to your local environment, please ensure you have sufficient space. | |||
There was a problem hiding this comment.
This is no longer true, if you're using file://
owen-t
approved these changes
May 9, 2018
apacker
pushed a commit
to apacker/sagemaker-python-sdk
that referenced
this pull request
Nov 15, 2018
Pyspark kmeans clustering on MNIST
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…passing uploading to/downloading from S3.
Issue #, if available:
Description of changes:
SDK now supports using training data stored on the local filesystem rather than expecting the data to be on s3.
Merge Checklist
Put an
xin the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.