breaking: rename s3_input to TrainingInput #1680

chuyang-deng · 2020-07-08T05:33:15Z

Issue #, if available:
#1473

Description of changes:
Rename s3_input to TrainingInput and remove warning message.

Testing done:
flake8,pylint,twine,black-check,sphinx,doc8
unit test

Merge Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.

General

I have read the CONTRIBUTING doc
I used the commit message format described in CONTRIBUTING
I have passed the region in to all S3 and STS clients that I've initialized as part of this change.
I have updated any necessary documentation, including READMEs and API docs (if appropriate)

Tests

I have added tests that prove my fix is effective or that my feature works (if appropriate)
I have checked that my tests are not configured for a specific region or account (if appropriate)
I have used unique_name_from_base to create resource names in integ tests (if appropriate)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

sagemaker-bot · 2020-07-08T05:40:43Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: bc4f20c
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2020-07-08T05:41:55Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: 495e289
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2020-07-08T05:59:58Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-notebook-tests
Commit ID: bc4f20c
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2020-07-08T06:00:41Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-notebook-tests
Commit ID: 495e289
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2020-07-08T06:07:35Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-zwei-pr
Commit ID: bc4f20c
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2020-07-08T06:13:22Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: 495e289
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2020-07-08T06:13:56Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: bc4f20c
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2020-07-08T17:35:45Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: 50ad633
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2020-07-08T17:53:08Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-notebook-tests
Commit ID: bc4f20c
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2020-07-08T17:56:12Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-notebook-tests
Commit ID: 50ad633
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2020-07-08T18:08:15Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: 50ad633
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2020-07-08T18:30:23Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-zwei-pr
Commit ID: 50ad633
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

laurenyu · 2020-07-08T22:06:39Z

src/sagemaker/session.py

+# import TrainingInput for backward compatibility
+from sagemaker.inputs import TrainingInput  # noqa # pylint: disable=unused-import


what do you think of removing this since we're making a breaking change anyway?

Yes, I think we should remove this as well.

I've updated the changes including the docstrings.

…thon-sdk into rename-s3-input

sagemaker-bot · 2020-07-09T06:21:12Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: 5f030dd
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2020-07-09T06:40:34Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-notebook-tests
Commit ID: 5f030dd
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2020-07-09T06:50:23Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-zwei-pr
Commit ID: 5f030dd
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2020-07-09T06:52:12Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: 5f030dd
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2020-07-09T07:13:48Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: a6e4830
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2020-07-09T07:40:46Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-notebook-tests
Commit ID: a6e4830
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2020-07-09T07:41:28Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-zwei-pr
Commit ID: a6e4830
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2020-07-09T07:48:29Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: a6e4830
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

laurenyu · 2020-07-09T16:17:01Z

(don't forget about updating the migration tool after merging this)

sagemaker-bot · 2020-07-09T16:43:35Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: 4cd044b
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2020-07-09T17:03:11Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-notebook-tests
Commit ID: 4cd044b
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2020-07-09T17:08:00Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-zwei-pr
Commit ID: 4cd044b
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2020-07-09T17:16:44Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: 4cd044b
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2020-07-09T17:27:15Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: 4cd044b
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

Chuyang Deng and others added 2 commits July 7, 2020 22:30

breaking: rename s3_input to TrainingInput

495e289

Merge branch 'zwei' into rename-s3-input

bc4f20c

Merge branch 'zwei' into rename-s3-input

50ad633

laurenyu reviewed Jul 8, 2020

View reviewed changes

Chuyang Deng added 2 commits July 8, 2020 23:12

remove TrainingInput import from session

d15f823

Merge branch 'rename-s3-input' of github.com:ChuyangDeng/sagemaker-py…

5f030dd

…thon-sdk into rename-s3-input

update docstring

a6e4830

laurenyu approved these changes Jul 9, 2020

View reviewed changes

Merge branch 'zwei' into rename-s3-input

4cd044b

chuyang-deng merged commit fed2fe9 into aws:zwei Jul 9, 2020

chuyang-deng mentioned this pull request Jul 10, 2020

change: add modifier for s3_input class #1699

Merged

7 tasks

		# import TrainingInput for backward compatibility
		from sagemaker.inputs import TrainingInput # noqa # pylint: disable=unused-import

breaking: rename s3_input to TrainingInput #1680

breaking: rename s3_input to TrainingInput #1680

Uh oh!

Conversation

chuyang-deng commented Jul 8, 2020

Merge Checklist

General

Tests

Uh oh!

sagemaker-bot commented Jul 8, 2020

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Jul 8, 2020

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Jul 8, 2020

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Jul 8, 2020

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Jul 8, 2020

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Jul 8, 2020

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Jul 8, 2020

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Jul 8, 2020

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Jul 8, 2020

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Jul 8, 2020

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Jul 8, 2020

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Jul 8, 2020

AWS CodeBuild CI Report

Uh oh!

laurenyu Jul 8, 2020

Choose a reason for hiding this comment

Uh oh!

chuyang-deng Jul 9, 2020

Choose a reason for hiding this comment

Uh oh!

sagemaker-bot commented Jul 9, 2020

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Jul 9, 2020

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Jul 9, 2020

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Jul 9, 2020

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Jul 9, 2020

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Jul 9, 2020

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Jul 9, 2020

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Jul 9, 2020

AWS CodeBuild CI Report

Uh oh!

laurenyu commented Jul 9, 2020

Uh oh!

sagemaker-bot commented Jul 9, 2020

AWS CodeBuild CI Report

Uh oh!