Skip to content

Add TF CIFAR test to continuous testing set #170

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 7, 2018

Conversation

laurenyu
Copy link
Contributor

@laurenyu laurenyu commented May 7, 2018

Description of changes:
Though this test has historically been relatively flaky, there was a recent change to the training steps that helped stabilize it, so it should be fine to include this test with our continuous testing. This test is important because it's currently our only one that tests distributed training and the only one to run on GPU instances.

Merge Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works (if appropriate)
  • I have updated the changelog with a description of my changes (if appropriate)
  • I have updated any necessary documentation (if appropriate)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Though this test has historically been relatively flaky, there was
a recent change to the training steps that helped stabilize it, so
it should be fine to include this test with our continuous testing.
This test is important because it's currently our only one that tests
distributed training and the only one to run on GPU instances.
@laurenyu laurenyu requested a review from mvsusp May 7, 2018 15:57
@codecov-io
Copy link

codecov-io commented May 7, 2018

Codecov Report

Merging #170 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #170   +/-   ##
=======================================
  Coverage   90.63%   90.63%           
=======================================
  Files          37       37           
  Lines        2478     2478           
=======================================
  Hits         2246     2246           
  Misses        232      232

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update de954b0...af5e24c. Read the comment docs.

Copy link
Contributor

@nadiaya nadiaya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's the test that takes longest time to run, right?
sigh

@laurenyu laurenyu merged commit a9717a0 into aws:master May 7, 2018
@laurenyu laurenyu deleted the add-cifar-to-continuous-tests branch May 7, 2018 19:17
apacker pushed a commit to apacker/sagemaker-python-sdk that referenced this pull request Nov 15, 2018
add xgboost mnist example for pyspark
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants