-
Notifications
You must be signed in to change notification settings - Fork 1.2k
feature: Add JSON Lines serializer #1760
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -192,6 +192,34 @@ def serialize(self, data): | |
return json.dumps(data) | ||
|
||
|
||
class JSONLinesSerializer(BaseSerializer): | ||
"""Serialize data to a JSON Lines formatted string.""" | ||
|
||
CONTENT_TYPE = "application/jsonlines" | ||
|
||
def serialize(self, data): | ||
"""Serialize data of various formats to a JSON Lines formatted string. | ||
|
||
Args: | ||
data (object): Data to be serialized. The data can be a string, | ||
list of JSON serializable objects, or a file-like object. | ||
|
||
Returns: | ||
str: The data serialized as a string containing newline-separated | ||
JSON values. | ||
""" | ||
if isinstance(data, str): | ||
return data | ||
|
||
if isinstance(data, list): | ||
bveeramani marked this conversation as resolved.
Show resolved
Hide resolved
|
||
return "\n".join(json.dumps(element) for element in data) | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This code will not serialize the last line correctly, according to the POSIX standard: https://pubs.opengroup.org/onlinepubs/9699919799/basedefs/V1_chap03.html#tag_03_206 |
||
|
||
if hasattr(data, "read"): | ||
return data.read() | ||
|
||
raise ValueError("Object of type %s is not JSON Lines serializable." % type(data)) | ||
|
||
|
||
class SparseMatrixSerializer(BaseSerializer): | ||
"""Serialize a sparse matrix to a buffer using the .npz format.""" | ||
|
||
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.