breaking: Add parameters to deploy and remove parameters from create_model #1783

bveeramani · 2020-07-30T23:21:47Z

Issue #, if available:

Description of changes:

Added serializer and deserializer parameters to deploy methods
Removed serializer, deserializer, content_type, and accept parameters from create_model

Testing done:

Modified appropriate tests

Merge Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.

General

I have read the CONTRIBUTING doc
I used the commit message format described in CONTRIBUTING
I have passed the region in to all S3 and STS clients that I've initialized as part of this change.
I have updated any necessary documentation, including READMEs and API docs (if appropriate)

Tests

I have added tests that prove my fix is effective or that my feature works (if appropriate)
I have checked that my tests are not configured for a specific region or account (if appropriate)
I have used unique_name_from_base to create resource names in integ tests (if appropriate)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

bveeramani · 2020-07-30T23:22:03Z

Prematurely opened this PR.

sagemaker-bot · 2020-07-30T23:30:16Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: 06f69b2
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2020-07-30T23:53:03Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-notebook-tests
Commit ID: 06f69b2
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

bveeramani · 2020-07-31T00:02:30Z

doc/frameworks/xgboost/using_xgboost.rst

+    serializer = StringSerializer()
+    serializer.CONTENT_TYPE = "text/libsvm"


This is pretty ugly, but it'll be replaced with LibSVMSerializer (#1776) when that gets merged.

sagemaker-bot · 2020-07-31T00:04:02Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: 06f69b2
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2020-07-31T00:10:03Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: 64024cb
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

bveeramani · 2020-07-31T00:11:44Z

Also, I realize that I forgot to update the documentation about removing two parameters from create_model. My next PR is dependent on merging this PR, so it'd be helpful if I can fix the documentation in a follow-up PR

sagemaker-bot · 2020-07-31T00:28:59Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-notebook-tests
Commit ID: 64024cb
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2020-07-31T00:43:42Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: 64024cb
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2020-07-31T01:00:13Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-zwei-pr
Commit ID: 64024cb
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

src/sagemaker/automl/automl.py

src/sagemaker/estimator.py

src/sagemaker/model.py

bveeramani · 2020-07-31T18:07:21Z

tests/integ/test_neo_mxnet.py

+        serializer = JSONSerializer()
+        serializer.CONTENT_TYPE = "application/vnd+python.numpy+binary"


The sample notebooks demonstrating Neo uses a serializer similar to NumpySerializer, but when I tried NumpySerializer I ran into errors.

The code above mimics the original behavior of the test. After doing more research on how Neo works, I can introduce the appropriate serializer

sagemaker-bot · 2020-07-31T18:10:37Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: ef53cc5
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2020-07-31T18:13:22Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: 67453e2
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2020-07-31T18:29:16Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-notebook-tests
Commit ID: ef53cc5
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2020-07-31T18:33:00Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-notebook-tests
Commit ID: 67453e2
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2020-07-31T18:43:18Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: ef53cc5
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2020-07-31T18:44:44Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: 67453e2
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2020-07-31T19:02:34Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-zwei-pr
Commit ID: 67453e2
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

Balaji Veeramani added 3 commits July 30, 2020 17:54

Update deploy method

82efce9

Merge branch 'zwei' into add-serde-params

a59a2c1

Update files

06f69b2

bveeramani closed this Jul 30, 2020

bveeramani changed the title ~~Add serde params~~ [WIP] Add serializer and deserialize parameters to deploy Jul 30, 2020

Fix tests

64024cb

bveeramani reopened this Jul 31, 2020

bveeramani commented Jul 31, 2020

View reviewed changes

bveeramani changed the title ~~[WIP] Add serializer and deserialize parameters to deploy~~ [WIP] Add serializer and deserializer parameters to deploy Jul 31, 2020

bveeramani changed the title ~~[WIP] Add serializer and deserializer parameters to deploy~~ [WIP] feature: Add serializer and deserializer parameters to deploy Jul 31, 2020

laurenyu reviewed Jul 31, 2020

View reviewed changes

src/sagemaker/automl/automl.py Outdated Show resolved Hide resolved

src/sagemaker/estimator.py Show resolved Hide resolved

src/sagemaker/model.py Show resolved Hide resolved

Update test_neo_mxnet.py

f4282ac

bveeramani changed the title ~~[WIP] feature: Add serializer and deserializer parameters to deploy~~ [WIP] breaking: Add parameters to deploy and remove parameters from create_model Jul 31, 2020

Balaji Veeramani and others added 2 commits July 31, 2020 13:02

Update docs

ef53cc5

Merge branch 'zwei' into add-serde-params

67453e2

bveeramani commented Jul 31, 2020

View reviewed changes

bveeramani changed the title ~~[WIP] breaking: Add parameters to deploy and remove parameters from create_model~~ breaking: Add parameters to deploy and remove parameters from create_model Jul 31, 2020

laurenyu approved these changes Jul 31, 2020

View reviewed changes

bveeramani merged commit cfa9c97 into aws:zwei Jul 31, 2020

bveeramani deleted the add-serde-params branch July 31, 2020 19:06

		serializer = StringSerializer()
		serializer.CONTENT_TYPE = "text/libsvm"

		serializer = JSONSerializer()
		serializer.CONTENT_TYPE = "application/vnd+python.numpy+binary"

breaking: Add parameters to deploy and remove parameters from create_model #1783

breaking: Add parameters to deploy and remove parameters from create_model #1783

Uh oh!

Conversation

bveeramani commented Jul 30, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merge Checklist

General

Tests

Uh oh!

bveeramani commented Jul 30, 2020

Uh oh!

sagemaker-bot commented Jul 30, 2020

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Jul 30, 2020

AWS CodeBuild CI Report

Uh oh!

bveeramani Jul 31, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

sagemaker-bot commented Jul 31, 2020

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Jul 31, 2020

AWS CodeBuild CI Report

Uh oh!

bveeramani commented Jul 31, 2020

Uh oh!

sagemaker-bot commented Jul 31, 2020

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Jul 31, 2020

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Jul 31, 2020

AWS CodeBuild CI Report

Uh oh!

Uh oh!

Uh oh!

Uh oh!

bveeramani Jul 31, 2020

Choose a reason for hiding this comment

Uh oh!

sagemaker-bot commented Jul 31, 2020

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Jul 31, 2020

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Jul 31, 2020

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Jul 31, 2020

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Jul 31, 2020

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Jul 31, 2020

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Jul 31, 2020

AWS CodeBuild CI Report

Uh oh!

Uh oh!

bveeramani commented Jul 30, 2020 •

edited

Loading

bveeramani Jul 31, 2020 •

edited

Loading