Skip to content

Fix: checking stopped status when waiting for logs #185

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 20, 2018
Merged

Fix: checking stopped status when waiting for logs #185

merged 3 commits into from
May 20, 2018

Conversation

sshekh
Copy link
Contributor

@sshekh sshekh commented May 15, 2018

*Issue #184 *

Job sent to JOB_COMPLETE state even when it is stopped

Merge Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.

  • [ x] I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works (if appropriate)
  • I have updated the changelog with a description of my changes (if appropriate)
  • I have updated any necessary documentation (if appropriate)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Fixes issue #184. Job goes into `JOB_COMPLETE` state even when it is stopped.
@codecov-io
Copy link

codecov-io commented May 15, 2018

Codecov Report

Merging #185 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #185   +/-   ##
=======================================
  Coverage   90.68%   90.68%           
=======================================
  Files          38       38           
  Lines        2599     2599           
=======================================
  Hits         2357     2357           
  Misses        242      242
Impacted Files Coverage Δ
src/sagemaker/session.py 87.41% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4760601...54fd325. Read the comment docs.

@andremoeller
Copy link
Contributor

andremoeller commented May 16, 2018

Hi @sshekh ,

I didn't notice you sent this PR for this issue, so I made my own with some unit tests (and another case we should cover): https://github.com/aws/sagemaker-python-sdk/pull/188/files

Can you incorporate those changes and update this PR?

Thanks!

@andremoeller
Copy link
Contributor

Hi @sshekh ,

FYI, I decided to reopen this PR to get these code changes merged in: #188

If you can update this PR soon, we can just merge yours in instead. Thanks!

@sshekh
Copy link
Contributor Author

sshekh commented May 19, 2018

Hi @andremoeller

Thanks for the quick response. Since I could not cherry-pick your commits, I just copied the changes and pushed them.

@andremoeller
Copy link
Contributor

andremoeller commented May 19, 2018

Hey @sshekh ,

EDIT: whoops, didn't realize I didn't merge that other PR in -- I'll run the tests and get this merged in. Thanks!

@andremoeller andremoeller merged commit 4f5cc41 into aws:master May 20, 2018
apacker pushed a commit to apacker/sagemaker-python-sdk that referenced this pull request Nov 15, 2018
Fixed: XGBoost direct marketing.  Train with CSV and update markdown.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants